Skip to content

Conversation

@daveespo
Copy link
Contributor

@daveespo daveespo commented Feb 13, 2025

This change is Reviewable

Copy link
Contributor Author

@daveespo daveespo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @ImJohnMDaniel and @stohn777)


sfdx-source/apex-common/test/classes/fflib_SObjectSelectorTest.cls line 632 at r1 (raw file):

	}

	private class ContractSelector extends fflib_SObjectSelector{

I'm hopeful that these objects, since they're standard Sales Cloud objects, should be accessible to all orgs (i.e. not hidden behind feature enablement)


sfdx-source/apex-common/test/classes/fflib_SObjectSelectorTest.cls line 37 at r1 (raw file):

	static testMethod void testGetSObjectName()
	{
		Testfflib_SObjectSelector selector = new Testfflib_SObjectSelector();

These fixture selectors were named so badly that I couldn't resist fixing them up to match the naming convention of the more modern ones

@ImJohnMDaniel ImJohnMDaniel merged commit e609d68 into master Feb 17, 2025
2 of 3 checks passed
@ImJohnMDaniel ImJohnMDaniel deleted the 494-allow-great-grandchildren branch February 17, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QueryFactory support for 5-level parent-child relationship subqueries Could fflib_QueryFactory now allow multiple nested subselects?

4 participants